Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] EB-124910 Adding pointer to extra key error dictionary field #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lautaro-eb
Copy link

@lautaro-eb lautaro-eb commented Oct 10, 2019

Adding pointer to extra key error dictionary field.
This will prevent not clear messages, for instance at the API level.

Needed Request Schema

{
    "performer": {
        "artist_id": 2
    }
}

Realized request

{
    "performer": {
        "artist_id": 2,
        "not_known_field": 12
    }
}

Response

{
    "status_code": 400,
    "error_description": "There are errors with your arguments: performer - UNKNOWN",
    "error": "ARGUMENTS_ERROR"
}

Expected response

{
    "status_code": 400,
    "error_description": "There are errors with your arguments: performer.not_known_field - UNKNOWN",
    "error": "ARGUMENTS_ERROR"
}

@lautaro-eb lautaro-eb changed the title [MINOR] EB-124910 Adding pointer to extra key error dictionary field [PATCH] EB-124910 Adding pointer to extra key error dictionary field Oct 10, 2019
tests/test_fields.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nickwilliams-eventbrite nickwilliams-eventbrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a temporary hold on this while we discuss on Slack.

Copy link
Contributor

@vartec vartec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is backwards incompatible change, and as such should be considered [MAJOR]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants